Implement cubic_interpolate() as MathFunc for refactoring
#57954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
changed the title
cubic_interpolate() as MathFunc to refactorcubic_interpolate() as MathFunc for refactoring
TokageItLab
force-pushed
the
refactor-cubic-interpolate
branch
3 times, most recently
from
cce2228
to
1032c0d
Compare
TokageItLab
force-pushed
the
refactor-cubic-interpolate
branch
from
1032c0d
to
69623ba
Compare
akien-mga
reviewed
Feb 11, 2022
akien-mga
reviewed
Feb 11, 2022
TokageItLab
force-pushed
the
refactor-cubic-interpolate
branch
from
69623ba
to
c38651f
Compare
aaronfranke
reviewed
Feb 11, 2022
TokageItLab
force-pushed
the
refactor-cubic-interpolate
branch
2 times, most recently
from
908ec7f
to
411882f
Compare
TokageItLab
force-pushed
the
refactor-cubic-interpolate
branch
from
411882f
to
865da09
Compare
|
I'd recommend calling it cubic_lerp instead to be in par with lerp function. |
|
@sairam4123 The "l" in "lerp" stands for "linear" so "cubic_lerp" would not be an appropriate name. We discussed the naming back when "lerp" was called "linear_interpolate" and decided to shorten it to "lerp", but "cubic_interpolate" does not have a common shortened version, "cerp" would sounds weird. |
|
As aaronfranke said right, lerp is an abbreviation for linear-interpolate. If you want to make a comparison, it would be more correct to make |
|
But there is slerp, so I thought cubic_lerp could work.
… The "l" in "lerp" stands for "linear" so "cubic_lerp" would not be an appropriate name. We discussed the naming back when "lerp" was called "linear_interpolate" and decided to shorten it to "lerp", but "cubic_interpolate" does not have a common shortened version, "cerp" would sounds weird.
|
akien-mga
approved these changes
Feb 13, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
cubic_interpolate()as built-in math function for refactoring animation and anywhere.This is the first step in solving #57952. We need to change the formula to solve #57952 completely, but since there were many duplicated formulas, this change put them in one place.