Change SCREEN_REFRESH_RATE_FALLBACK to -1.0 #57938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordi-star
changed the title
akien-mga
reviewed
Feb 10, 2022
akien-mga
reviewed
Feb 10, 2022
akien-mga
reviewed
Feb 10, 2022
jordi-star
force-pushed
the
negative-refresh-rate-fallback
branch
from
48925e5
to
84a18b4
Compare
akien-mga
reviewed
Feb 10, 2022
doc/classes/DisplayServer.xml
Outdated
| To fallback to a default refresh rate if the method fails, try: | ||
| [codeblock] | ||
| var refresh_rate = DisplayServer.screen_get_refresh_rate() | ||
| if refresh_rate < 0: |
There was a problem hiding this comment.
The XML parser chokes on this, should be <.
jordi-star
force-pushed
the
negative-refresh-rate-fallback
branch
from
84a18b4
to
3a371da
Compare
akien-mga
approved these changes
Feb 10, 2022
akien-mga
reviewed
Feb 11, 2022
doc/classes/DisplayServer.xml
Outdated
| [codeblock] | ||
| var refresh_rate = DisplayServer.screen_get_refresh_rate() | ||
| if refresh_rate < 0: | ||
| refresh_rate = 60.0 |
There was a problem hiding this comment.
Should use 4 spaces for indentation in the codeblock (while keeping the tab based indentation of the <description> block).
jordi-star
force-pushed
the
negative-refresh-rate-fallback
branch
from
3a371da
to
7a9972a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If DisplayServer.screen_get_refresh_rate fails, return -1.0 instead of 60.0 to allow for better error handling.
Relates to godotengine/godot-proposals#1284 (comment)