Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong RGBA channel mapping when saving OpenEXR. #56715

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

fire
Copy link
Member

@fire fire commented Jan 12, 2022

Fixes: #55472

This is not broken in Godot Engine 4.0.

@fire
Copy link
Member Author

fire commented Jan 12, 2022

Some differences on the edges compared with the original.

image

image

@akien-mga
Copy link
Member

Seems like your commit message got truncated? And it wrongly references OpenXR (the XR standard) instead of OpenEXR / EXR.

@fire fire changed the title Make openxr save in 3.x. Make openexr save in 3.x. Jan 12, 2022
@fire fire changed the title Make openexr save in 3.x. Fix wrong RGBA channel mapping when saving OpenEXR Jan 12, 2022
@fire fire changed the title Fix wrong RGBA channel mapping when saving OpenEXR Fix wrong RGBA channel mapping when saving OpenEXR. Jan 12, 2022
@Chaosus Chaosus added this to the 3.5 milestone Jan 12, 2022
@akien-mga akien-mga merged commit 21d52c6 into godotengine:3.x Jan 12, 2022
@akien-mga
Copy link
Member

Thanks!

@fire fire deleted the exr-save-3 branch January 12, 2022 11:15
@akien-mga
Copy link
Member

Cherry-picked for 3.4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants