Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to EditorResourcePicker #56398

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jan 1, 2022

The PR does various improvements to EditorResourcePicker

  • added support for Image -> ImageTexture conversion (part of Add more inspector Resource auto-conversions #55727)
  • when doing conversion and a matching resource already exists, don't create new resource, but replace data instead (this is somewhat similar to Assign value to property by dropping to scene tree #50517, e.g. you can drop a texture on an existing StandardMaterial3D to replace current texture instead of creating new material)
  • fixed a bug where clearing resource wouldn't clear the tooltip
  • fixed Texture -> StandardMaterial3D not working
  • added resource type to tooltip (similar to scene tree dock)
    image

@KoBeWi KoBeWi added enhancement topic:editor usability cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jan 1, 2022
@KoBeWi KoBeWi added this to the 4.0 milestone Jan 1, 2022
@YuriSizov
Copy link
Contributor

Looks good at a glance! Note that some names have changed in master, so a cherrypick would require manual renames. Probably worth making a dedicated 3.x PR.

@akien-mga akien-mga merged commit 8f6cba3 into godotengine:master Jan 5, 2022
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the cooler_picker branch January 5, 2022 16:43
@timothyqiu
Copy link
Member

Cherry-picked for 3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants