Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Add drag and drop to TextEdit, LineEdit, RichTextLabel #55355

Merged
merged 1 commit into from
Mar 14, 2022
Merged

[3.x] Add drag and drop to TextEdit, LineEdit, RichTextLabel #55355

merged 1 commit into from
Mar 14, 2022

Conversation

ConteZero
Copy link
Contributor

Add drag and drop operation for TextEdit, LineEdit and RichTextLabel (only drag).
This is a backport of 55294 54339 55207 from master to 3.x branch.

@ConteZero ConteZero requested review from a team as code owners November 26, 2021 15:22
@Calinou Calinou added this to the 3.5 milestone Nov 26, 2021
@ConteZero ConteZero force-pushed the drag_and_drop_3.x branch 7 times, most recently from cd42629 to 922e6b5 Compare November 29, 2021 21:45
@ConteZero ConteZero mentioned this pull request Feb 5, 2022
Closed
KoBeWi
KoBeWi approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and appears to be working correctly. Didn't check the code, but if it was accepted for master, I assume it's probably ok too (someone could check it though).

@akien-mga akien-mga requested a review from bruvzg March 14, 2022 06:24
bruvzg
bruvzg approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

scene/gui/text_edit.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga changed the title Add drag and drop to TextEdit, LineEdit, RichTextLabel [3.x] Add drag and drop to TextEdit, LineEdit, RichTextLabel Mar 14, 2022
@akien-mga akien-mga merged commit 08c3e00 into godotengine:3.x Mar 14, 2022
@akien-mga
Copy link
Member

Thanks!

@ConteZero ConteZero deleted the drag_and_drop_3.x branch March 15, 2022 08:02
@akien-mga akien-mga mentioned this pull request Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui usability
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ConteZero @akien-mga @KoBeWi @bruvzg @Calinou