Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak "No Undo" texts for consistency #55233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 22, 2021

All "No Undo" texts are now written in uppercase to be more noticeable, since there's a risk of data loss.

All "No Undo" texts are now written in uppercase to be more noticeable,
since there's a risk of data loss.
@akien-mga
Copy link
Member

I'm not sure about this, it seems tricky for localization. I wouldn't know how to translate this to French without having something super cumbersome and aggressive looking (like "PAS D'ANNULATION").

It's also not a proper English sentence so might be difficult to translate even as is. Maybe we can rethink this UX?

For example this could be a second paragraph in the ConfirmationDialog:

Clear inheritance?

Important: This action cannot be undone.

@Calinou
Copy link
Member Author

Calinou commented Nov 22, 2021

For example this could be a second paragraph in the ConfirmationDialog:

Clear inheritance?

Important: This action cannot be undone.

For dialogs, this is a good idea. However, I'm not sure about buttons that include a "No Undo" text such as the "Replace All" button in the Replace in Files dialog.

@YuriSizov
Copy link
Contributor

However, I'm not sure about buttons that include a "No Undo" text such as the "Replace All" button in the Replace in Files dialog.

There is some space there, we can add a (bold?) label next to the button with more explicit text.

@@ -6265,7 +6265,7 @@ AnimationTrackEditor::AnimationTrackEditor() {
cleanup_all->set_text(TTR("Clean-up all animations"));
cleanup_vb->add_child(cleanup_all);

cleanup_dialog->set_title(TTR("Clean-Up Animation(s) (NO UNDO!)"));
cleanup_dialog->set_title(TTR("Clean-Up Animation(s) (NO UNDO)"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be in the text instead of title, like in other cases?

This comment was marked as outdated.

@akien-mga
Copy link
Member

Would be good to update this based on the discussion so far, I think the proposed changes would make the UX much nicer already.

@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 9, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 14, 2023
@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 26, 2023
@akien-mga akien-mga modified the milestones: 4.3, 4.x Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants