Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure C# script properties are added to the end #54423

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos commented Oct 30, 2021

Follow-up to #54130
Closes #54414

Ensures that the get_property_list and get_script_property_list methods push the script properties to the end of the given list, this prevents the script property from appearing after the script variables.

In my previous PR I was assuming the list parameter came empty so using push_front directly was pushing the script properties in front of the script property, this PR uses a different list for the script properties and pushes them to the back at the end of the method like the GDScript implementation.

Before After
[node name="MyNode" type="Node"]
number = 42
script = ExtResource( 1 )
[node name="MyNode" type="Node"]
script = ExtResource( 1 )
number = 42

Ensures that the `get_property_list` and `get_script_property_list`
methods push the script properties to the end of the given list, this
prevents the script property from appearing after the script variables.
@akien-mga akien-mga merged commit 2074647 into godotengine:master Oct 31, 2021
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the csharp-exports-ii branch October 31, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C# Export members no more initialized
3 participants