Fix MIDI input with ALSA #54309
Merged
Fix MIDI input with ALSA #54309
+154
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force pushed a fix for an issue with aborted SysEx messages in my previous attempt |
Reworked the handling of ALSA RawMidi input to support: - Running Status. - RealTime Category messages arriving during other messages data. - Multiple connected RawMidi interfaces.
|
Rebased and retested |
reduz
approved these changes
Oct 27, 2022
|
Thanks! |
akien-mga
added
the
cherrypick:3.x
|
Cherry-picked for 3.6 |
timothyqiu
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked the handling of ALSA RawMidi input to support:
Running Status,
RealTime Category messages arriving during other messages data,
multiple connected RawMidi interfaces.
Fixes #54276
Note, this doesn't expand
InputEventMIDIor add any of the System Common or Real-Time Category message types to theMidiMessageListenum. Just fixes the ALSA input to match behavior of the CoreMIDI and Windows versions.