Make EditorSpinSlider wait for idle_frame to update text on key_up/down #54288
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 26, 2021
editor/editor_spin_slider.cpp
Outdated
| @@ -424,6 +426,14 @@ void EditorSpinSlider::_notification(int p_what) { | |||
| _update_value_input_stylebox(); | |||
| break; | |||
|
|
|||
| case NOTIFICATION_PROCESS: | |||
There was a problem hiding this comment.
process is not the right way to implement the dirty flag pattern, a call_deferred() call would be better.
There was a problem hiding this comment.
I did try call_deferred(), and it was unfortunately still too early. By the time the deferred call to the function happened, an idle frame still hadn't happened and the setter hadn't been called yet.
There was a problem hiding this comment.
Then it should at least use NOTIFICATION_INTERNAL_PROCESS so that it doesn't conflict with user-defined set_process() calls.
There was a problem hiding this comment.
Forgot about that! Issued a fix.
Razoric480
force-pushed
the
fix-key-up-down-idle-frame
branch
from
db089ac
to
3f3cd15
Compare
akien-mga
approved these changes
Oct 26, 2021
akien-mga
added
the
cherrypick:3.x
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54287. This ensures that the text is up to date with any setters that may modify the value.