Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Alt + Mouse wheel to adjust FOV in the 3D editor viewport #53820

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 14, 2021

master version of #54207.

This allows for quicker FOV adjustments compared to using the View menu.

This closes godotengine/godot-proposals#3428.

Preview

3d-editor-quick-fov-adjust.mp4

Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Calinou Are there any other uses other than zoom via fov? Zoom speed up is the regular mouse wheel. Trying to see if anything else can use this valuable spot.

The proposal is to make it easier to pick an object in the scene far away. This achieves that.

Can you check what happens when the values are infinite or nan?

This introduces two ways to pick an object in the scene far away.

  1. fov changes
  2. physically move

@jcostello
Copy link
Contributor

Do we have a reset command or button?

@Calinou
Copy link
Member Author

Calinou commented Oct 15, 2021

Can you check what happens when the values are infinite or nan?

The FOV scale is clamped between 0.1 and 2.5 (it defaults to 1.0). The final FOV is clamped between 1 and 179 degrees, so it's impossible to reach a zero, infinite or NaN value.

Do we have a reset command or button?

Resetting is done by setting the FOV in the 3D viewport's View menu or restarting the editor. The FOV scale factor will be set back to 1.0 when you press OK in the dialog.

This allows for quicker FOV adjustments compared to using the View menu.
@Calinou
Copy link
Member Author

Calinou commented Oct 23, 2021

Added keyboard shortcuts to increase FOV (Ctrl + Minus), decrease FOV (Ctrl + Plus) and reset FOV (Ctrl + 0).

@Calinou Calinou force-pushed the 3d-editor-add-quick-fov-adjust branch from f6d381c to 5ae45cf Compare October 23, 2021 10:22
@akien-mga akien-mga merged commit 69eaa80 into godotengine:master Oct 24, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Note: This was reverted in #64070.

@Calinou
Copy link
Member Author

Calinou commented Aug 8, 2022

Note: This was reverted in #64070.

To clarify, only Alt + mouse wheel was removed. The keyboard shortcuts are still here and they can be adjusted in the editor settings, as they usually don't get in the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a shortcut to adjust FOV in the 3D editor viewport
4 participants