Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve editor panning and remove RMB panning #53471

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 6, 2021

This PR does a couple of things:

  • Improves cursor refreshing. Now _update_cursor() will automatically refresh the cursor shape if it's different from previous one (also fixes a regression from Request immediate refresh of cursor in 2D editor while using shortcuts #37336 where cursor would change even if not over 2D viewport)
  • Pan View shortcut (Space by default) will automatically change cursor to CURSOR_DRAG while being pressed
    • Updated the panning mode tooltip to mention this shortcut
  • Removes RMB panning, as it got in a way of properly using RMB in the editor (see Add tool quick-select to tile editor #51695 for example). We had 3 ways to pan view anyways

Copy link
Member

@groud groud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of this PR. I think having the right click available in the editor should allow several interesting thing, such as popping a context menu or do specific actions with some editors.

We need to pay attention to whether or not we have any complain about that though, I would not be surprised if it would annoy some users.

@sairam4123
Copy link

I am not favour of removing the RMB because it's difficult for me to pan around in the the 2D editor without it.

@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 6, 2021

@sairam4123 And what about Space panning? You can change it to any other key if preferred, there's also a setting called "Simple Panning" which allows to use this shortcut without LMB (like in GIMP for example).

@sairam4123
Copy link

That's pretty good then. LMB panning would really help.

@jordanlis
Copy link

jordanlis commented Oct 7, 2021

I am in favor of this PR. I think having the right click available in the editor should allow several interesting thing, such as popping a context menu or do specific actions with some editors.

We need to pay attention to whether or not we have any complain about that though, I would not be surprised if it would annoy some users.

Totally agree with him : this features (right click -> menu) is totally missing. For example, it would be so usefull to right-click in the editor, then create a new node or instance a new scene at the mouse cursor's coordinates.
Like asked here : godotengine/godot-proposals#435

@akien-mga akien-mga merged commit 7494d54 into godotengine:master Oct 12, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants