[Net] Removed blocking network address resolution in connect_to_host in websockets #53262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordo
changed the title
jordo
force-pushed
the
PR-connect_to_host_master
branch
from
f9181ea
to
1b15d86
Compare
|
fixes #53265 for websocket clients |
Faless
changed the title
Faless
requested changes
Dec 15, 2021
There was a problem hiding this comment.
I am deeply sorry for the very long review time, I have been sucked up by the work on the replication API.
This change looks okay, it is a bit of a mess that this has to be handled down in every peer separately, but it's definitely an improvement so I would merge this once the review comments are addressed.
Good work 👍
| Vector<String> _protocols; | ||
| Vector<String> _original_protocols; |
There was a problem hiding this comment.
I don't understand why we need the _original_protocols.
It seems there is already the _protocols variable that could be used.
| _connection = _tcp; | ||
|
|
||
| _key = WSLPeer::generate_key(); | ||
| // TODO custom extra headers (allow overriding this too?) |
There was a problem hiding this comment.
We can remove this TODO since we now support extra headers (was a leftover from the other PR I guess).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master pr for #53243 (untested)
Bugsquad edit: fixes #53265 for websocket clients