Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Add empty translation files to the editor app bundle, to allow translation detection by the OS. #52945

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 22, 2021

Adds a bunch of empty Info.plist translation files to ensure macOS is detecting supported languages correctly.

System language settings:
Screenshot 2021-09-22 at 20 42 27

@bruvzg bruvzg marked this pull request as ready for review September 22, 2021 20:33
@bruvzg bruvzg requested a review from a team as a code owner September 22, 2021 20:33
@bruvzg
Copy link
Member Author

bruvzg commented Sep 22, 2021

macOS detects all locales, except "pr" Pirate.

But locale auto selection does not work with some languages since editor do not check only for a full match or locale with the language code only.

Editor locales are zh_CN, zh_TW, zh_HK and sr_Cyrl.
OS locales zh_Hans_{your_countly_code}, zh_Hant_{your_countly_code}, zh_Hant_HK and sr_{your_countly_code}.

Locale selection code definitely need some improvement.

@akien-mga akien-mga merged commit e6ffb10 into godotengine:master Nov 8, 2021
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the macos_editor_translation branch November 9, 2021 05:43
@akien-mga akien-mga added cherrypick:3.4 cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Feb 3, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 10, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants