GLTF for game templates. #52802
Merged
GLTF for game templates. #52802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
force-pushed
the
gltf-extensions
branch
from
bc1e0c1
to
e7b6311
Compare
fire
force-pushed
the
gltf-extensions
branch
from
e7b6311
to
815c123
Compare
fire
changed the title
fire
force-pushed
the
gltf-extensions
branch
2 times, most recently
from
ded31fc
to
fbab48d
Compare
Closed
10 tasks
fire
force-pushed
the
gltf-extensions
branch
8 times, most recently
from
155f8ba
to
3ca60c9
Compare
|
Blend shapes should work now. |
fire
force-pushed
the
gltf-extensions
branch
6 times, most recently
from
f910743
to
437934f
Compare
fire
commented
Sep 18, 2021
fire
force-pushed
the
gltf-extensions
branch
3 times, most recently
from
ce33d12
to
b286a10
Compare
|
fire
commented
Sep 21, 2021
fire
force-pushed
the
gltf-extensions
branch
from
ff98000
to
27c7a8a
Compare
This comment has been minimized.
This comment has been minimized.
fire
force-pushed
the
gltf-extensions
branch
5 times, most recently
from
af83243
to
806bfb8
Compare
fire
force-pushed
the
gltf-extensions
branch
2 times, most recently
from
ba75f44
to
a831fa3
Compare
reduz
requested changes
Oct 3, 2021
Convert GLTF Document to use ImporterMeshInstance3D. Add a GLTFDocument extension list and an extension for converting the importer mesh instance 3d to mesh instance 3d. Use GLTF module when the editor tools are disabled. Modified the render server to be less restrictive on matching blend arrays and have more logging. Misc bugs with multimesh. Always index the meshes.
reduz
approved these changes
Oct 4, 2021
|
Thanks! |
|
Hi, I'm a bit curious why GLTFDocumentExtensionConvertImporterMesh is disabled when not I don't see any reason why that extension needs to behave differently in the editor vs not. |
|
@lyuma there are a few things I would change in GLTFDocument and one of them may be getting rid of the GLTF* classes and make them internal structs accessible by index, but I wanted to at least get this merged so it does not block other areas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GLTFDocument extension list and an extension for converting mesh instance 3d to the editor mesh node.
Use GLTF module when the editor tools are disabled.
GLTF should work in a game template.
For godotengine/godot-proposals#3305 and also for godotengine/godot-proposals#3273