Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] C#, replace the current Xform method with a * operator. #52762

Merged
merged 1 commit into from
Sep 18, 2021
Merged

[3.x] C#, replace the current Xform method with a * operator. #52762

merged 1 commit into from
Sep 18, 2021

Conversation

magian1127
Copy link
Contributor

@magian1127 magian1127 commented Sep 17, 2021 •
edited
Loading

Backport #52666

@magian1127 magian1127 requested a review from a team as a code owner September 17, 2021 05:56
@Calinou Calinou added this to the 3.4 milestone Sep 17, 2021
@aaronfranke aaronfranke self-requested a review September 17, 2021 14:12
aaronfranke
aaronfranke previously requested changes Sep 18, 2021
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this and I can confirm that the functionality is correct. The style looks good to me too. So all that's left is to improve the XML doc comments.

modules/mono/glue/GodotSharp/GodotSharp/Core/Transform2D.cs Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit bb2772d into godotengine:3.x Sep 18, 2021
@akien-mga
Copy link
Member

Thanks!

@magian1127 magian1127 deleted the 3.xTemp1 branch September 19, 2021 09:03
@andy-noisyduck andy-noisyduck mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neikeq neikeq neikeq approved these changes

@akien-mga akien-mga akien-mga approved these changes

@aaronfranke aaronfranke Awaiting requested review from aaronfranke

Assignees
No one assigned
Labels
enhancement topic:dotnet
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@magian1127 @akien-mga @aaronfranke @neikeq @Calinou