Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.4] Fix InputMap.action_erase_event() failing to erase events correctly. #52737

Merged
merged 1 commit into from
Sep 17, 2021
Merged

[3.4] Fix InputMap.action_erase_event() failing to erase events correctly. #52737

merged 1 commit into from
Sep 17, 2021
+57 −40

Conversation

EIREXE
Copy link
Contributor

@EIREXE EIREXE commented Sep 16, 2021

(3.x backport of 7104229)

Fixes #52733

@EIREXE EIREXE requested review from a team as code owners September 16, 2021 05:12
@Calinou Calinou added this to the 3.4 milestone Sep 16, 2021
@EIREXE EIREXE force-pushed the action_erase_fix branch 2 times, most recently from 15d2efc to 4e76768 Compare September 16, 2021 08:10
@akien-mga
Copy link
Member

Renaming shortcut_match breaks compat, so it can't be done in 3.x. It should keep its original name.

@EIREXE
Copy link
Contributor Author

EIREXE commented Sep 16, 2021

Renaming shortcut_match breaks compat, so it can't be done in 3.x. It should keep its original name.

Fixed

@akien-mga akien-mga merged commit 16ca275 into godotengine:3.x Sep 17, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Sep 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:input
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@EIREXE @akien-mga @Calinou @YuriSizov