Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Allow pinning property values + Consistent property defaults #52234

Closed

Conversation

RandomShaper
Copy link
Member

@RandomShaper RandomShaper commented Aug 29, 2021

Version of #52233 for 3.x. See details there.

However, there's an important difference: the binary scene file format is kept compatible, by storing the pinned flag in the MSB of other field. (The compatibility node about scene text format still holds.)

@RandomShaper RandomShaper changed the title Property pin control 3.x [3.x] Allow pinning property values + Consistent property defaults Aug 29, 2021
@RandomShaper RandomShaper force-pushed the property_pin_control_3.x branch 12 times, most recently from 543308b to d503697 Compare September 4, 2021 22:46
@RandomShaper RandomShaper force-pushed the property_pin_control_3.x branch 10 times, most recently from fb48615 to 28c392b Compare September 13, 2021 16:27
@RandomShaper RandomShaper marked this pull request as ready for review September 14, 2021 12:50
@RandomShaper RandomShaper requested review from a team as code owners September 14, 2021 12:50
@RandomShaper RandomShaper force-pushed the property_pin_control_3.x branch 4 times, most recently from 53cc64f to 802ce99 Compare September 17, 2021 12:16
@RandomShaper
Copy link
Member Author

I'll change this back to draft since I'm working on an alternative approach (still compatible with the proposal). The first commit will stay the same.

@RandomShaper RandomShaper marked this pull request as draft September 17, 2021 13:07
@RandomShaper RandomShaper force-pushed the property_pin_control_3.x branch 3 times, most recently from b3b86ab to bf5549d Compare September 19, 2021 17:31
@RandomShaper
Copy link
Member Author

Superseded by #52944.

@RandomShaper RandomShaper deleted the property_pin_control_3.x branch September 22, 2021 17:31
@RandomShaper RandomShaper added this to the 3.4 milestone Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants