Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renaming directories #51793

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Fix renaming directories #51793

merged 1 commit into from
Aug 17, 2021

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Aug 17, 2021

Fixes #48254

Seems like dir_exists() is less strict with names, e.g. "" or ".." are valid directories even though it will result in the same bug as #41623, so I added some basic checks for invalid paths.

@KoBeWi KoBeWi added bug topic:core topic:gdscript regression cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Aug 17, 2021
@KoBeWi KoBeWi added this to the 4.0 milestone Aug 17, 2021
@KoBeWi KoBeWi requested a review from a team as a code owner August 17, 2021 12:19
core/core_bind.cpp Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

Maybe also update the doc which currently only mentions files.

@akien-mga akien-mga merged commit 913a7a6 into godotengine:master Aug 17, 2021
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the direnam branch August 17, 2021 14:15
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 18, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

toasterofbread added a commit to toasterofbread/godot that referenced this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Godot 3.3.2, scripts cannot use rename() to change folder names
2 participants