Add support for partial custom editor themes #51651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
masterversion of #51648.Additionally this PR removes
copy_theme()andcopy_default_theme()from theThemeresource. Frankly, I don't see a point in them, and they weren't consistent. All resource items (icons, styleboxes, fonts) were added to the base theme, while all the other, primitive types were completely replaced. So I am not sure what the actual purpose of the methods has been, but if anyone relied on it — it was probably a bad decision. I've removed the only place in the editor where we relied on one of them (because it wasn't actually necessary).The new
merge_with()can be used to add all items from another theme, and standardduplicate()can be called if you want a copy of the resource. So I think the removal of those two methods is justified.