[3.x] Implement specular occlusion in SpatialMaterial #50603
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
changed the title
Specular occlusion works by: - Applying specular occlusion and horizon specular occlusion as advised by Filament: google.github.io/filament/Filament.html#lighting/occlusion/specularocclusion - Always treating Light Affect is if it was set to 1.0 for the purposes of specular lighting. It is an approximate effect with a very low performance cost, but makes specular reflections more believable overall.
Calinou
force-pushed
the
3d-add-specular-occlusion-3.x
branch
from
dcd063e
to
cc21323
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3
to
c58391c
Compare
Calinou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.xversion of #50601.Unlike #50601,
ao_light_affectisn't taken into account at this point in the shader, so we don't need to move it.Specular occlusion works by:
It is an approximate effect with a very low performance cost, but makes specular reflections more believable overall.
Preview
GLES3
GLES2