Fix _shape_shape typos in TileData collision shape API

[Xrayez]

According to existing add_collision_shape() and remove_collision_shape(), the renamed methods should be set/get_collision_shape(), and not set/get_collision_shape_shape().

---

This PR is generously donated by Goost.

[groud]

This is superseded by #49859 where I got rid of those functions. Shapes are getting replaced by a polygon instead, so I removed those functions.

But no, this was not a typo anyway, add_collision_shape and remove_collision_shape removes also the data associated with the shape (one_way and one_way_margin), while set/get_collision_shape_shape() only affect the Shape2D resource. I would have liked to find a better name but well, I did not.

[Xrayez]

The issue with method naming in #49859 still persists: _polygon_polygon(). If you really want to be explicit with this kind of API, most of the time, there are better alternatives, like: _polygon_points(), or _polygon_vertices(), or even with shape it would be _shape_resource().

[groud]

The issue with method naming in #49859 still persists: _polygon_polygon(). If you really want to be explicit with this kind of API, most of the time, there are better alternatives, like: _polygon_points(), or _polygon_vertices(), or even with shape it would be _shape_resource().

Ah my bad you are right, I can change that then. Though I'm not sure there's a real problem with it TBH.

[Xrayez]

Though I'm not sure there's a real problem with it TBH.

To be honest, I submitted this PR immediately because I really thought there was an obvious copy-paste mistake regardless. Even Chaosus assigned the "bug" label to this PR. We should give good example for everyone reading the Godot's codebase, especially for new contributors, and especially when people tend to take existing Godot code as a reference for their own code.

[akien-mga]

Superseded by #49859.