Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OptionButton to DropDownList #49827

Conversation

madmiraal
Copy link
Contributor

As originally mentioned in #6558, the OptionButton is actually a Drop-Down List.

This PR renames OptionButton to DropDownList.

Closes godotengine/godot-proposals#1998

@aaronfranke
Copy link
Member

aaronfranke commented Jun 22, 2021

Can we just call it DropDown (or similar)? I don't think the "List" suffix is ideal for a node type.

@groud
Copy link
Member

groud commented Jun 22, 2021

Can we just call it DropDown (or similar)? I don't think the "List" suffix is ideal for a node type.

I was thinking maybe we should go for DropDownButton, since it inherits from Button.

@madmiraal
Copy link
Contributor Author

I don't think the "List" suffix is ideal for a node type.

We already have ItemList

I was thinking maybe we should go for DropDownButton, since it inherits from Button.

It's only a Button, because, within the engine, it inherits Button, but it's a Drop-Down List. Note: Checkbox also inherits Button, but it's not called CheckboxButton. I think it should be called what it is.

@MaaaxiKing
Copy link

A bit long, but DropDownListButton would be the most correct and detailed one.

@aaronfranke
Copy link
Member

It's only a Button, because, within the engine, it inherits Button, but it's a Drop-Down List.

Isn't it a button that creates a drop-down list when clicked?

@MaaaxiKing
Copy link

Strictly speaking, yes.

@reduz
Copy link
Member

reduz commented Jul 30, 2022

Is not the most common name for this to be ComboBox ? We have CheckBox already.

@madmiraal
Copy link
Contributor Author

A Combobox is something different. A Combobox is a DropDownList with a single line, editable text box that we call a LineEdit that allows the user to either select one of the DropDownList items or enter their own value.

@YuriSizov
Copy link
Contributor

The proposal was approved, but we picked a different option. This PR is pretty old, so it's better it is remade from scratch for the new name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

Rename OptionButton to DropDownList
6 participants