-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename OptionButton to DropDownList #49827
Rename OptionButton to DropDownList #49827
Conversation
Can we just call it DropDown (or similar)? I don't think the "List" suffix is ideal for a node type. |
I was thinking maybe we should go for DropDownButton, since it inherits from Button. |
We already have
It's only a |
A bit long, but |
Isn't it a button that creates a drop-down list when clicked? |
Strictly speaking, yes. |
Is not the most common name for this to be ComboBox ? We have CheckBox already. |
A |
The proposal was approved, but we picked a different option. This PR is pretty old, so it's better it is remade from scratch for the new name. |
As originally mentioned in #6558, the
OptionButton
is actually aDrop-Down List
.This PR renames
OptionButton
toDropDownList
.Closes godotengine/godot-proposals#1998