Tweak CSG shape defaults for consistency with primitive meshes #49729
+32
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
tweak-csg-shape-defaults
branch
from
e149382
to
6e4c6d8
Compare
- Increase the default level of detail (but not too much since updating CSG is expensive).
Calinou
force-pushed
the
tweak-csg-shape-defaults
branch
from
6e4c6d8
to
db928c1
Compare
|
Not sure what the point of this is |
The point is to have a slightly better level of detail by default, and ensure consistency with PrimitiveMeshes in terms of default dimensions. That said, if you think the increased level of detail would cause too many performance issues out of the box, I can change this PR to only change the CSG nodes' default dimensions. |
|
I definitely would not change the amount of detail of the CSG shapes, but seems good to make sure dimensions match. |
|
This PR is no longer necessary as of 4.0.alpha13, as CSG shape default dimensions now match primitive meshes' default dimensions. CSG meshes on the front, primitive meshes at the back:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
MeshInstances on the front, CSG nodes on the back.