Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading RLE compressed TGAs and invalid memory reads. #49593

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Fix loading RLE compressed TGAs and invalid memory reads. #49593

merged 1 commit into from
Jun 14, 2021

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 14, 2021

  • Fix loading RLE compressed TGA files
  • Fix memory reads outside of input buffer when loading invalid TGA files.

Fixes #48592
Fixes #46549

Tested with a bunch of images saved by GIMP, and test files from #45702 and #46549.

@bruvzg
Fix loading RLE compressed TGA files.
25cd29a 
Fix memory reads outside of input buffer when loading invalid TGA files.
@bruvzg bruvzg added bug topic:import cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jun 14, 2021
@bruvzg bruvzg added this to the 4.0 milestone Jun 14, 2021
@bruvzg bruvzg requested a review from a team as a code owner June 14, 2021 11:00
@bruvzg bruvzg mentioned this pull request Jun 14, 2021
Merged
@bruvzg bruvzg removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jun 14, 2021
fire
fire approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@fire fire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source code review looks fine. It's weird how the bug was an > vs >=.

Did not QA the test cases.

@akien-mga akien-mga merged commit 72f39e3 into godotengine:master Jun 14, 2021
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the tga_loader_fixes branch June 15, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug topic:import
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

TGA files with RLE compression no longer work Invalid memory read when importing broken tga files
3 participants
@bruvzg @akien-mga @fire