-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand bone name possibilities. #47074
Conversation
Updated test project. |
I noticed something weird where I lose the animation track. Doing another testing pass. |
I took https://github.com/KhronosGroup/glTF-Sample-Models/blob/master/2.0/RiggedSimple/glTF-Binary/RiggedSimple.glb and renamed the bones to The |
Since there are only two trivial patterns, maybe you could use And so for bones we don't need to apply the same replaces as in |
I'll use replace. Also, they never used the same replaces as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please also remove the #include
for the RegEx module.
Thanks! |
Cherry-picked for 3.3. |
Reduce the limits on bone names.
Continues: https://github.com/godotengine/godot/pull/46939/files
Fixes: #43482
Fixes: godotengine/godot-proposals#1855