-
-
Notifications
You must be signed in to change notification settings - Fork 20.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Array, Dictionary and Variant.duplicate() to copy() #46996
Conversation
The problem with |
I think this is even more reason why |
19942c1
to
c87c5d7
Compare
Rebased following 4ca1e73. |
c87c5d7
to
b5867d4
Compare
b5867d4
to
2b70265
Compare
Updated documentation with |
2b70265
to
23223ee
Compare
Rebased following 29775a1. |
Does the same internally for Vector<>, which includes all PackedArray types.
23223ee
to
46c23db
Compare
We discussed this in a PR review meeting today and the consensus was that we didn't see much value in the rename. As long as we're consistent in our own API, I think keeping |
Does the same internally for
Vector<>
, which includes allPackedArray
types.Part of #16863.
Note: The original suggestion suggested either
copy()
orclone()
and #16863 actually suggestsclone()
, but all the documentation uses the work "copy" in the descriptions; so I think it makes more sense to usecopy()
.