Rationalize property reversion #46270
Merged
+57
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
added
bug
topic:editor
cherrypick:3.x
RandomShaper
force-pushed
the
fix_can_reset
branch
4 times, most recently
from
37f5fd5
to
36daf9b
Compare
RandomShaper
changed the title
|
I'll still do some additional testing and then I'll post a comment when I feel it's ready. |
RandomShaper
force-pushed
the
fix_can_reset
branch
from
36daf9b
to
db9e3f2
Compare
|
OK. In any case, it may be better to have in 4.0 for some period of time before considering cherry-picking into 3.x, just in case. |
akien-mga
approved these changes
Jul 31, 2021
|
Thanks! |
RandomShaper
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the algorithm used to determine if a reset (circle arrow) icon must be shown on a property in the editor, which means the current value is different from the default one (the one in the scene it instances or inherits from, the default as declared in the script or the default according to the builtin class).
This PR aims to fix some defects in the current algorithm. For instance, the complaint that in a derived scene the value considered the default for a property is the default in the parent script, instead of the one in the parent, which may already be overriding the default in the script, so that is the new default that matters. (See this complaint: godotengine/godot-proposals#2280 (comment))
UPDATE: After an additional push, it also ensures the value a property gets reverted to is the same that was considered to check for "revertability".
UPDATE: Some additional little issues have been taken care of.
Fixes #50781.
UPDATE: Separate version needed for 3.x: #51166