Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Improved Inspector Sub-Resource Editing #45940

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

hoontee
Copy link
Contributor

@hoontee hoontee commented Feb 12, 2021

Backport of #45907.

@hoontee
Copy link
Contributor Author

hoontee commented Feb 12, 2021

Didn't feel like waiting ¯\_(ツ)_/¯

If any substantial changes occur, I can backport them as well.

CC @Xrayez

@hoontee hoontee marked this pull request as ready for review February 12, 2021 23:46
@YeldhamDev YeldhamDev added this to the 3.2 milestone Feb 13, 2021
Copy link
Contributor

@Xrayez Xrayez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like magic!

image

Configuring tint via docks/property_editor/subresource_hue_tint editor setting also works (0.4):

image

@SirPigeonz
Copy link
Contributor

Thank you for back porting this!

@rick551a
Copy link

Excited for this, will it be in 3.2.4?

@Xrayez
Copy link
Contributor

Xrayez commented Feb 13, 2021

Consider rebasing your PR to latest 3.2, your current branch is still on 3.2.3-rc which was 7 months ago according to commit history. 🙂

It took me much longer to compile the engine because of that, and other folks might want to test this PR as well.

@RPicster
Copy link
Contributor

compare
It may be considered "spam". I just wanted to drop by and let you know how thankful I am for the backport to 3.2

I work a lot with the SmartShape2D Plugin and the resources and sub resources there are a real hell to work with.

Above is a screenshot comparing the two variants and it is obvious how much better the elements are distiguishable 👏

@akien-mga
Copy link
Member

Consider rebasing your PR to latest 3.2, your current branch is still on 3.2.3-rc which was 7 months ago according to commit history. slightly_smiling_face

Indeed, please rebase. I'm surprised it can even be merged without conflicts, but if the base branch is so old, there's no guarantee that it won't actually break the build once merged on 3.2 (the current CI build ran with the config from the base branch).

@hoontee
Copy link
Contributor Author

hoontee commented Feb 18, 2021

Rebased to f30d827.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO.

@akien-mga akien-mga merged commit 07b66ee into godotengine:3.2 Feb 18, 2021
@akien-mga
Copy link
Member

Thanks!

@hoontee hoontee deleted the backport-45907 branch February 18, 2021 18:09
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants