Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Pin Android NDK r21 as we don't support r22 yet #45132

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Jan 12, 2021

Cf. #44055.

GitHub Actions deployed NDK r22 on their Ubuntu 20.04 image today: actions/runner-images#2420

This will slow down builds as we redownload the NDK each time. If anyone wants to look into how to include in the cache, that would be welcome.

@@ -6,6 +6,7 @@ env:
GODOT_BASE_BRANCH: master
SCONSFLAGS: platform=android verbose=yes warnings=extra werror=yes --jobs=2 module_text_server_fb_enabled=yes
SCONS_CACHE_LIMIT: 4096
ANDROID_NDK_VERSION: 21.1.6352462
Copy link
Member Author

@akien-mga akien-mga Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m4gr3d Had to pin this version for now as Gradle would still try to use 21.1.6352462 even if I pre-installed 21.3.6528147 and set it as ANDROID_NDK_ROOT. Hopefully #44949 should solve that.

@akien-mga akien-mga merged commit df257f4 into godotengine:master Jan 12, 2021
@akien-mga akien-mga deleted the ci-android-ndk-pin-r21 branch January 12, 2021 18:32
@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant