Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTML5] Fix master build #45071

Merged
merged 4 commits into from
Jan 10, 2021
Merged

[HTML5] Fix master build #45071

merged 4 commits into from
Jan 10, 2021
+77 −40

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Jan 10, 2021

In this PR:

  • Usual RasterizerDummy sync. This time quite a lot of changes.
  • Fix WebXR module build, few methods were renamed in the XR interface and broke the build.
  • Fix MainLoop interactions after Rename MainLoop methods to match Node methods #44593 .
  • A small fix to the build script to better handle externs dependencies that should be backported to 3.2 (I'll make a separate PR for that)

@Faless
Sync RasterizerDummy.
88300af
@Faless
Fix WebXR module.
eb53048 
Some functions and enums were renamed in 4.0 but not updated in the
WebXR code.
@Faless
Fix JavaScript platform after MainLoop methods rename.
33e914b
@Faless
[HTML5] Reorganize build script.
c327f42 
Simplify helper functions, fix env/sys_env confusion and depends for
externs and pre-js.
@Faless Faless added this to the 4.0 milestone Jan 10, 2021
@Faless Faless mentioned this pull request Jan 10, 2021
Merged
@Faless Faless merged commit a594243 into godotengine:master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:web topic:buildsystem topic:porting
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Faless @akien-mga