SCons: Add explicit dependencies on thirdparty code in cloned env #44457
+602
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
topic:buildsystem
topic:thirdparty
cherrypick:3.x
akien-mga
requested review from
AndreaCatania,
JFonS and
a team
as code owners
akien-mga
force-pushed
the
scons-thirdparty-lib-depends
branch
from
9aa74b7
to
a82163e
Compare
|
Tested on Windows 10: |
bruvzg
reviewed
Dec 17, 2020
Thanks, I'll look into it further. It works for the way bullet is handled, but maybe the explicit dependency on StaticLibraries created in the TextServer module doesn't work. |
|
Hm I could reproduce (and fix) the issue with This is what I get after adding an unused define in So the |
Since we clone the environments to build thirdparty code, we don't get an explicit dependency on the build objects produced by that environment. So when we update thirdparty code, Godot code using it is not necessarily rebuilt (I think it is for changed headers, but not for changed .c/.cpp files), which can lead to an invalid compilation output (linking old Godot .o files with a newer, potentially ABI breaking version of thirdparty code). This was only seen as really problematic with bullet updates (leading to crashes when rebuilding Godot after a bullet update without cleaning .o files), but it's safer to fix it everywhere, even if it's a LOT of hacky boilerplate.
akien-mga
force-pushed
the
scons-thirdparty-lib-depends
branch
from
a82163e
to
c7b53c0
Compare
Hm, I have tested it a few times again, and it seems to work, probably I messed up with the changed files or accidentally ran scons twice. |
|
Backported to |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we clone the environments to build thirdparty code, we don't get an
explicit dependency on the build objects produced by that environment.
So when we update thirdparty code, Godot code using it is not necessarily
rebuilt (I think it is for changed headers, but not for changed .c/.cpp files),
which can lead to an invalid compilation output (linking old Godot .o files
with a newer, potentially ABI breaking version of thirdparty code).
This was only seen as really problematic with bullet updates (leading to
crashes when rebuilding Godot after a bullet update without cleaning .o files),
but it's safer to fix it everywhere, even if it's a LOT of hacky boilerplate.
Supersedes the SCons changes in #44455 by applying them to the whole codebase.