Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icons for Gradient and GradientTexture resources #44259

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

gongpha
Copy link
Contributor

@gongpha gongpha commented Dec 10, 2020

These new icons will look consistent with another icon.

Old

ภาพ
ภาพ

New

ภาพ
ภาพ

Edit : Wait for #42855 to be merged first.

@akien-mga
Copy link
Member

The GradientTexture icon looks good, but the Gradient icon is too similar to GradientTexture with the rectangular outline which only differs by a few pixels.

@akien-mga akien-mga added this to the 4.0 milestone Dec 10, 2020
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 10, 2020
@Calinou
Copy link
Member

Calinou commented Dec 10, 2020

Maybe GradientTexture's gradient could be flipped to be in the opposite direction?

@gongpha
Copy link
Contributor Author

gongpha commented Dec 10, 2020

Sounds good, Or should Gradient's icon rotate like an old one ?

@gongpha
Copy link
Contributor Author

gongpha commented Dec 10, 2020

Modified.

ภาพ
ภาพ

@Xrayez
Copy link
Contributor

Xrayez commented Dec 10, 2020

I'm not sure whether GradientTexture2D is going to be merged at all in Godot: #42855, but then I'm not sure what should be the icon for 2D texture, perhaps the old icon of GradientTexture should be the new icon for GradientTexture2D? 😃

In any case, that's something I'd like to implement in either case (in Goost), so worth to discuss the design in relation to 2D texture.

@gongpha gongpha force-pushed the new-gradient-icon branch 3 times, most recently from e7a1e46 to 1a5d589 Compare December 11, 2020 03:52
@gongpha
Copy link
Contributor Author

gongpha commented Dec 11, 2020

@Xrayez When should the #42855 be merged ?

@Xrayez
Copy link
Contributor

Xrayez commented Dec 11, 2020

@gongpha godotengine/godot-proposals#1677 has to be officially approved first, technically could be merged right now, but there are other limitations which would be good to resolve to make it robust: #43015.

@gongpha
Copy link
Contributor Author

gongpha commented Dec 11, 2020

@Xrayez Meanwhile, I made a local commit with GradientTexture2D's icon. I designed it to look different from GradientTexture. But I still use grey as an icon color like the original one. Because it doesn't associate with Node2D nodes.

However, I will sit here for #42855. When it ready, I will push them here. 🙂

@Xrayez
Copy link
Contributor

Xrayez commented Dec 13, 2020

@gongpha just letting you know that I've added GradientTexture2D in Goost with goostengine/goost#43, for now I'm just using the same GradientTexture icon in editor/icons/icon_gradient_texture_2d.svg, so feel free to contribute there as well. 🙂

Of course I'd still prefer #42855 to get merged too.

@gongpha
Copy link
Contributor Author

gongpha commented Dec 14, 2020

@Xrayez I'm currently working on these icons. I read your commits in goostengine/goost#43. I saw that your changes include radial gradient and I'm still hesitating with these icons. You can help me pick one with the best fit for its purpose !

ภาพ

@Xrayez
Copy link
Contributor

Xrayez commented Dec 14, 2020

@gongpha thanks, I think the diagonal one is a good fit, this signifies that linear gradient can have arbitrary direction in 2D. The linear gradient is the default one so it's not necessary to have a radial icon displayed (many other types could be implemented in the future as well...)

image

@gongpha
Copy link
Contributor Author

gongpha commented Dec 15, 2020

Current :

ภาพ
ภาพ

@gongpha gongpha marked this pull request as draft January 3, 2021 12:23
@gongpha gongpha marked this pull request as ready for review May 18, 2021 01:52
@gongpha gongpha requested a review from a team as a code owner May 18, 2021 01:52
@Calinou
Copy link
Member

Calinou commented Jun 2, 2021

I think the new icons are easy enough to distinguish from each other.

@akien-mga akien-mga merged commit af3ebc9 into godotengine:master Jun 3, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jun 3, 2021
@gongpha gongpha deleted the new-gradient-icon branch June 3, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants