Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect plugins recursively #43734

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Detect plugins recursively #43734

merged 1 commit into from
Jan 20, 2021

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Nov 21, 2020

Recursion doesn't go deeper after finding plugin.cfg (to avoid including subplugins). Also plugin_addons now contains full paths with the configuration file (it looks even simpler and more efficient).

I do not know any plugins for 4.0, so I tested this changes on 3.2 and it works as expected.

Closes godotengine/godot-proposals#1623.
References godotengine/godot-proposals#554.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature looks good to me (and will be needed in some form for the new asset library in the future), although I haven't tested this PR.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it's a good idea, and the code changes look fine (I haven't tested though). Let's merge and see how it goes in the master branch before considering merging the 3.2 version too.

@akien-mga akien-mga merged commit 39cf47f into godotengine:master Jan 20, 2021
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Shatur Shatur deleted the detect-plugins-recursively branch January 20, 2021 10:02
@Jummit
Copy link
Contributor

Jummit commented Feb 18, 2021

Let's merge and see how it goes in the master branch before considering merging the 3.2 version too.

I would like to organize some plugins using folders, so any news about backporting?
This is also step one of godotengine/godot-proposals#2091

@Shatur
Copy link
Contributor Author

Shatur commented Feb 18, 2021

@Jummit, I already backported it in #45316.

@Jummit
Copy link
Contributor

Jummit commented Feb 18, 2021

@Jummit, I already backported it in #45316.

Oh, sorry. I should've seen the link to that issue in the history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect plugins recursively
5 participants