-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.2] [iOS] Keyboard input changes #43560
Conversation
Since this PR changes how |
I've finally tested on Android and spotted an issue. It doesn't seem to be platform specific. Repro steps are: There's an error in the log when the virtual keyboard is triggered:
On this line in the new code:
I can confirm Can you reproduce this issue on iOS? I haven't tested on master, so I'm not sure if the 4.0 version of this PR has the same problem. |
c9dc48b
to
02ff98d
Compare
@pouleyKetchoupp thanks! |
Found some strange bug. My old test project gives me incorrect text input and duplicates the text. |
To fix the bug you mentioned I think this line:
Can be replaced with:
Apart from that it seems to work fine now! |
Yup, I'm waiting for a build to test it right now :) Edit: Seems to be fixed now with latest commit. |
02ff98d
to
e8b1171
Compare
e8b1171
to
f1fd044
Compare
On Android, this PR also fixes the same issues #38309 did for |
Thanks! |
Added a
cursor_start
andcursor_end
parameters forTextEdit
control.Changed a way iOS's keyboard is handled by moving handing into separate class. Now it can display suggestions view for languages that require it. This change also allows to receive text changes made by dictation or any other text input method.
Fixes #43256 for
3.2
branch