-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add append_array() method to Array class #43398
Add append_array() method to Array class #43398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also consistent with Packed*Array
s which have append_array
.
In the proposal @Zylann raises a good point about potentially missing the opportunity to optimize the godotengine/godot-proposals#1718 (comment) This shouldn't prevent merging this for consistency with |
That might be a bit tricky. For this to work well I think Variant should provide the "assign with operation" operator as well. From GDScript it's hard to tell if the code isn't typed. |
Further comments from IRC:
So changing |
Thanks! |
Cherry-picked for 3.2.4. |
Closes godotengine/godot-proposals#1718
Vector class (used internally by Array) already had
append_array
method, so this PR pretty much only exposes it.