Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using SVG images as project icon #43369

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 6, 2020

Since exporters will save their own icon, the target platforms don't have to support SVG to display the icon correctly.

In the future, we could consider supporting SVG favicons in the HTML5 export (whose support is quite good). This would require two things:

  • If the project icon is in SVG format, modify the loading logic to copy the SVG icon from the project as favicon.svg and reference it in the HTML.
  • When a SVG project icon is used, ignore requests to change the project icon from Godot itself, as it can only set a rasterized version of the icon. Perhaps this should be placed behind a project setting.

This closes #23068.

Preview

image

Since exporters will save their own icon, the target platforms
don't have to support SVG to display the icon correctly.

This closes godotengine#23068.
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:core labels Nov 6, 2020
@Calinou Calinou added this to the 4.0 milestone Nov 6, 2020
@akien-mga
Copy link
Member

Since exporters will save their own icon, the target platforms don't have to support SVG to display the icon correctly.

I think at least Android uses the project icon by default, so this should likely be tested to confirm that it works.

@akien-mga akien-mga merged commit 5d89b1a into godotengine:master Nov 10, 2020
@akien-mga
Copy link
Member

Thanks!

@Riteo
Copy link
Contributor

Riteo commented Nov 11, 2020

May I suggest to include this small tweak also into 3.2.4, if it's possible? It should be pretty easy to port(one small change into main.cpp) and shouldn't break anything.

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 11, 2020
@Calinou Calinou deleted the allow-svg-project-icon branch March 31, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow choosing .svg files for game icons
3 participants