[3.x] Return RID instead of Object id in area-body_shape_entered-exited signals.

[madmiraal]

3.2 version of #42742.

[capnm]

The debugger doesn't like it;)

[madmiraal]

The debugger is saying the RID is not a valid resource of the Area or RigidBody that is running the code, which is true. It is, however, a valid RID of the PhysicsServer.

[madmiraal]

Rebased following merge of #42715.

[pouleyKetchoupp]

For info, the Invalid RID message is due to a known general issue with RID type in the debugger: #33797

[akien-mga]

The master PR was merged, so this should be mergeable once rebased too.

[akien-mga]

Thanks!

[belzecue]

Today I tested my 3.3.2 3D project against 3.4 beta2 and this RID change broke my project and stopped collisions for area-body_shape_entered-exited signal. The reason is the pre-3.4 default typing of body_id as Int for signal template code:

func _on_Area_body_shape_entered(body_id: int, body: Node, body_shape: int, local_shape: int) -> void:
	var parent := body.get_parent()
	var parent_class := parent.get_class()

	parent.visible = true
	if parent_class == "OmniLight":
		omnilight_controller._on_Camera_collider_entered(parent)

Once I switched body_id types to the new RID typing, everything went back to working fine.

func _on_Area_body_shape_entered(body_id: RID, body: Node, body_shape: int, local_shape: int) -> void:

[pouleyKetchoupp]

You should get an error similar to this one at runtime:
ERROR: Error calling method from signal 'area_shape_entered': 'Area(Area.gd)::_on_Area_area_shape_entered': Cannot convert argument 1 from RID to int..

But it would be great to get an error in the script too. I wonder how complicated it would be to add.

[belzecue]

You should get an error similar to this one at runtime

That is the case, yes. I missed seeing it first time around, in my panic :)