Update area-body_shape_entered-exited signal documentation. #42713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmiraal
force-pushed
the
fix-42614
branch
4 times, most recently
from
56137e9
to
3e2a9e6
Compare
|
Rebased following merge of #42881. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42614.
Updates the documentation of the
area_shape_entered,area_shape_exited,body_shape_enteredandbody_shape_exitedsignals forAreasandRigidBodies2D and 3D to clearly state what each of the parameters provide.Added a second commit to rename the final parameter of the Area
area_shape_entered,area_shape_exited,body_shape_enteredandbody_shape_exitedsignals tolocal_shapeto make it consistent withRigidBodyand remove the confusion that it may refer to the enteringArea's shape.