Only display the Windows toggle console option if it can actually be used #42065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 14, 2020
|
BTW, I think we should restore the previous logic where a debug build would default to building in console mode. Many users are confused in the current |
bruvzg
reviewed
Sep 14, 2020
Calinou
force-pushed
the
editor-toggle-console-subsystem
branch
from
b6f187d
to
4df86f8
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if we should hide the option entirely or just disable it with a tooltip instead. Feedback welcome 🙂
Note: Not cherry-pickable to the
3.2branch since this PR depends on #41332.