Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reverse playback for animtree #41728

Closed
wants to merge 1 commit into from
Closed

Implement reverse playback for animtree #41728

wants to merge 1 commit into from
+191 −78

Conversation

TokageItLab
Copy link
Member

For #21665 and #27215.

  • Since it is assumed to be a non-reverse play, find() gets the key frame just before the current time.
  • Also, the Animation Node was interfering with the loop and root motion.

This fix solves these issues and implements a negative Time Scale in the Animation Tree.

https://www.youtube.com/watch?v=iPIG41NEgyM

I've uploaded a sample project to be used for testing.

animation_tracks_test.zip
reverse_root_motion.zip

@TokageItLab TokageItLab mentioned this pull request Sep 2, 2020
Closed
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:core labels Sep 2, 2020
@Calinou Calinou added this to the 4.0 milestone Sep 2, 2020
@fire
Copy link
Member

fire commented Sep 10, 2020

We discussed how root motion support needs to be tested.

@TokageItLab
Copy link
Member Author

TokageItLab commented Sep 11, 2020 •
edited
Loading

Those have been resolved.
Previously, the root_motion was Transform.IDENTITY when seeking. With this fix, that value will be the difference between the root motion before and after the seek. If you want to keep the previous behavior, please implement that it does not apply the root_motion when seeking in GDScript.

@TokageItLab TokageItLab reopened this Sep 30, 2020
@TokageItLab
Copy link
Member Author

TokageItLab commented Sep 30, 2020 •
edited
Loading

I cleaned up commits

@TokageItLab TokageItLab mentioned this pull request Dec 7, 2020
Open
@TokageItLab TokageItLab mentioned this pull request Jan 10, 2021
Closed
@Shatur
Copy link
Contributor

Shatur commented Mar 21, 2021

What is the status of it?

@daleblackwood

This comment has been minimized.

Sign in to view
@Calinou

This comment has been minimized.

Sign in to view
This was referenced Apr 29, 2021
Closed
Merged
@TokageItLab TokageItLab requested a review from a team as a code owner May 1, 2021 12:34
@TokageItLab
Copy link
Member Author

TokageItLab commented Aug 11, 2021 •
edited
Loading

Superseded by #48332.

@akien-mga akien-mga added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Aug 11, 2021
@TokageItLab
Copy link
Member Author

note: salvageable for 3.x

@TokageItLab TokageItLab deleted the implement-reverse-playback branch September 16, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived enhancement salvageable topic:animation topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@TokageItLab @fire @Shatur @daleblackwood @Calinou @aaronfranke @akien-mga