ios microphone recording bugfix #41592
Conversation
Calinou
added
cherrypick:3.x
| @@ -142,7 +142,7 @@ Error AudioDriverCoreAudio::init() { | |||
|
|
|||
| unsigned int buffer_size = buffer_frames * channels; | |||
| samples_in.resize(buffer_size); | |||
| input_buf.resize(buffer_size); | |||
| input_buf.resize(buffer_size * 2); | |||
There was a problem hiding this comment.
I assume it's to fix:
a "-50" error from AudioUnitRender in audio_driver_coreaudio.cpp whenever microphone input is enabled. This is because bufferList.mBuffers[0].mDataByteSize is too small, since there is a mismatch between the capture buffer format and the audio device.
Maybe buffer size should be calculated separately form output buffer size, without using output_latency and mix_rate, these properties are for output. Set to the fixed size or add another property?
There was a problem hiding this comment.
I agree with your point. " * 2" looks definitely a magic number. I hope someone who knows well this audio part can help to fix it in the near future because I'm not an expert in regards to this. On the other hand, fortunately, this file only has to do with the iPhone devices and this change works well on them, so making changes little by little would be also great.
There was a problem hiding this comment.
On the other hand, fortunately, this file only has to do with the iPhone devices and this change works well on them, so making changes little by little would be also great.
This file is also used for macOS, so I guess it should be tested there too just in case.
I also think it would be better to calculate input_buffer_size separately or make it into constant/define. This should make it easier to read and maintain.
There was a problem hiding this comment.
Let's revert it and fix it later then. When I have some time to do it, I'll give it a try.
|
Could you squash the two commits into one? |
|
I'm sorry, I started working for a game engine company this month, so I can't keep my contribution to any other game engines because it's dealt with outside activity. This change is necessary for iOS, so I believe someone can also contribute it instead of me. |
akien-mga
added
archived
salvageable
and removed
cherrypick:3.x
Fixes #33885