Add FOG, RADIANCE, and IRRADIANCE shader overrides #41415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduz
requested changes
Oct 18, 2020
clayjohn
force-pushed
the
VULKAN-shader-overrides
branch
from
5649100
to
f46932f
Compare
reduz
approved these changes
Oct 18, 2020
|
Does this PR make it possible to implement godotengine/godot-proposals#411 with a shader? |
|
@Calinou probably! I am a little unclear on exactly what that effect is. but now you can do anything you want! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with reduz on IRC.
This allows users to implement their own custom fog, radiance, and irradiance by overriding the default behaviour.
Closes #33616
In short, all 3 built ins just blend between the override and the internal value.
Documentation PR to follow.