Add GDScript code generation abstraction #41338
Merged
+2,820
−1,774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this close godotengine/godot-proposals#1176? Alternatively, does this PR make that proposal non-applicable? |
No and no. It might make a tad easier to implement that though, as it could be done as an implementation of this interface without having to touch the compiler. |
jonbonazza
reviewed
Aug 18, 2020
#41355 should get you there. 🙂 |
vnen
force-pushed
the
gdscript-compiler-abstraction
branch
2 times, most recently
from
261afb0
to
2f74b37
Compare
Implement the abstraction by targeting the current VM.
vnen
force-pushed
the
gdscript-compiler-abstraction
branch
from
2f74b37
to
8963035
Compare
vnen
force-pushed
the
gdscript-compiler-abstraction
branch
from
8963035
to
635c6a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an interface for code generation to GDScript. In itself it does not make much of a difference, but it does make it easier to add a new backend without having to worry about the parse tree, instead just implementing a lower-level interface.
This will be useful for the new typed VM, since it can be made without creating a new compiler code. Could also be useful in the future if we want to compile GDScript to other targets.
Also includes a disassembler for the current VM which I used to debug the code generation. It can't be accessed currently since the command for the old tests isn't available anymore, but this is useful to have for when we have a new way to trigger those.