Make GraphNode handle children with EXPAND flag #39810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christinoleo
force-pushed
the
master
branch
3 times, most recently
from
e5dc35a
to
3fd88ab
Compare
Calinou
added
bug
cherrypick:3.x
|
@christinoleo Is this still desired? If so, it needs to be rebased and tested on the latest master branch. |
|
@aaronfranke Thanks for bringing this up. I have updated the commit to the latest commit in godot/master. |
groud
approved these changes
Mar 9, 2021
|
Thanks @groud |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current GraphNode implementation ignores the EXPAND flags of children. This reuses the code of box_container.cpp in a way to allow GraphNode to handle it. It fixes #7804.
This is my first contribution, so any feedback, tips or updates are very welcome! I also wanted to know how to update the 3.2 branch as well (like, another PR?), or if I should not do anything regarding 3.2.