Remove ToolButton in favor of Button #39690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs. Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. This closes godotengine/godot-proposals#1081.
|
Thanks! |
akien-mga
reviewed
Jun 24, 2020
Comment on lines
+222
to
+236
| // Button | ||
|
|
||
| theme->set_stylebox("normal", "ToolButton", make_empty_stylebox(6, 4, 6, 4)); | ||
| theme->set_stylebox("pressed", "ToolButton", make_stylebox(button_pressed_png, 4, 4, 4, 4, 6, 4, 6, 4)); | ||
| theme->set_stylebox("hover", "ToolButton", make_stylebox(button_normal_png, 4, 4, 4, 4, 6, 4, 6, 4)); | ||
| theme->set_stylebox("disabled", "ToolButton", make_empty_stylebox(6, 4, 6, 4)); | ||
| theme->set_stylebox("focus", "ToolButton", focus); | ||
| theme->set_font("font", "ToolButton", default_font); | ||
| theme->set_stylebox("normal", "Button", make_empty_stylebox(6, 4, 6, 4)); | ||
| theme->set_stylebox("pressed", "Button", make_stylebox(button_pressed_png, 4, 4, 4, 4, 6, 4, 6, 4)); | ||
| theme->set_stylebox("hover", "Button", make_stylebox(button_normal_png, 4, 4, 4, 4, 6, 4, 6, 4)); | ||
| theme->set_stylebox("disabled", "Button", make_empty_stylebox(6, 4, 6, 4)); | ||
| theme->set_stylebox("focus", "Button", focus); | ||
| theme->set_font("font", "Button", default_font); | ||
|
|
||
| theme->set_color("font_color", "ToolButton", control_font_color); | ||
| theme->set_color("font_color_pressed", "ToolButton", control_font_color_pressed); | ||
| theme->set_color("font_color_hover", "ToolButton", control_font_color_hover); | ||
| theme->set_color("font_color_disabled", "ToolButton", Color(0.9, 0.95, 1, 0.3)); | ||
| theme->set_color("font_color", "Button", control_font_color); | ||
| theme->set_color("font_color_pressed", "Button", control_font_color_pressed); | ||
| theme->set_color("font_color_hover", "Button", control_font_color_hover); | ||
| theme->set_color("font_color_disabled", "Button", Color(0.9, 0.95, 1, 0.3)); | ||
|
|
||
| theme->set_constant("hseparation", "ToolButton", 3); | ||
| theme->set_constant("hseparation", "Button", 3); |
There was a problem hiding this comment.
@Calinou You wondered why all Buttons now look like ToolButtons? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToolButton has no redeeming differences with Button; it's just a Button with the Flat property enabled by default. Removing it avoids some confusion when creating GUIs.
Existing ToolButtons will be converted to Buttons, but the Flat property won't be enabled automatically. Help is welcome for doing this 🙂
This closes godotengine/godot-proposals#1081.
Process
For future reference, here's the process I followed to make this PR:
(^.+)([a-z0-9_]+) = memnew\(ToolButton\);$1$2 = memnew(Button);\n$2->set_flat(true);ToolButtonwithButton(case-sensitive).#include "scene/gui/tool_button.h"with#include "scene/gui/button.h".scene/register_scene_types.cpp.scene/register_scene_types.cpp:.cppand.hfiles.