Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the GodotPlugin public API. #39580

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Clean up the GodotPlugin public API. #39580

merged 1 commit into from
Jun 16, 2020

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Jun 15, 2020

Clean up and add javadocs to portions of the GodotPlugin API.

Backport for PR #39579

@m4gr3d m4gr3d added this to the 3.2 milestone Jun 15, 2020
@m4gr3d m4gr3d requested review from akien-mga and a team June 15, 2020 21:26
@m4gr3d m4gr3d force-pushed the provide_activity_to_godot_plugin_constructor_3_2 branch from 48382dc to 7059316 Compare June 15, 2020 21:27
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Jun 15, 2020

@akien-mga This should be one of the last updates to the GodotPlugin public API for 3.2.2, and should future-proof us for upcoming changes in 3.2.3

@m4gr3d m4gr3d force-pushed the provide_activity_to_godot_plugin_constructor_3_2 branch from 7059316 to 61aa477 Compare June 16, 2020 16:24
@akien-mga akien-mga merged commit 7f67674 into godotengine:3.2 Jun 16, 2020
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the provide_activity_to_godot_plugin_constructor_3_2 branch June 16, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga Awaiting requested review from akien-mga

Assignees
No one assigned
Labels
enhancement platform:android topic:plugin
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@m4gr3d @akien-mga