Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file dialog filename cleared when selecting favorites #38994

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

nikibobi
Copy link
Contributor

@nikibobi nikibobi commented May 23, 2020

There is a UX bug when I click to navigate to one of my favorite locations the filename gets cleared.
This doesn't happen when changing folders or picking an item from recent and I think favorites should work the same (see screenshots).

image
image

@nikibobi nikibobi marked this pull request as ready for review May 23, 2020 23:52
@Calinou Calinou added this to the 4.0 milestone Jan 5, 2021
@akien-mga akien-mga requested a review from a team February 18, 2021 22:34
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 18, 2021
Copy link
Contributor

@EricEzaM EricEzaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I wonder if there was originally a reason for this... Either way, seems fine.

@akien-mga akien-mga merged commit aeea428 into godotengine:master Feb 19, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants