-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the Dummy audio driver in the project manager #38208
Use the Dummy audio driver in the project manager #38208
Conversation
I'm not sure it's worth hacking it this way. If Godot uses too much CPU due to the coreaudio driver, working it around only in the project manager doesn't help much as 99% of user time is spent in the editor itself. And if we ever decide to add sound features to the project manager (e.g. for accessibility), it might lead to some wasted hours trying to figure out why it's not outputting any audio. |
If we add screen reader support, I think the application emitting sound would be the screen reader, not Godot. |
That depends on how it's implemented. I've done a bit of work to help out the developer of this screen reader editor plugin, and while I don't think it works in the project manager, using the dummy audio driver would completely prevent any future in-process accessibility tools from working |
5e75b83
to
af3050b
Compare
Rebased and tested again, it works successfully 🙂
The project manager doesn't support plugins yet, so I think this PR would be fine to merge for now. Also, if project manager plugins ever become supported, I guess we could have a way to initialize the audio driver only when a sound is actually played for the first time. (This would be opt-in for games because this adds significant latency to the first sound.) |
af3050b
to
eb7903a
Compare
This could potentially be superceded by a 4.x version of #63458 . The ability to mute until audio output in the PR means that it would also work with screen reading software. |
This prevents Godot from appearing in the list of applications outputting sound in the OS while the user is in the project manager.
eb7903a
to
da4683c
Compare
Rebased and tested again, it works as expected. Note that TTS audio output is not emitted by Godot itself (but by the OS instead), so this doesn't affect potential screen-reader support in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is simple enough that it's fine to merge IMO. Even if it doesn't solve the mentioned issue, there is some minimal benefit.
Thanks! |
This prevents Godot from appearing in the list of applications outputting sound in the OS while the user is in the project manager.
This also partially addresses #38154.