-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Ctrl for switching between editors, bind F2 to Rename Node #38201
Conversation
Switching between editors now requires holding Ctrl to avoid conflicts with the new F2 shortcut. The asset library can now be accessed by pressing Ctrl + F4 on Windows and Linux, or Alt + 4 on macOS. This partially addresses godotengine#38139.
Do they not work at all or do they do something else? KDE has a LOT of shortcuts it uses, IIRC Ctrl+F2 is 'switch to desktop 2'. My personal fav is ctrl+= and ctrl+- zooming regardless of what app I have <3 |
@Zireael07 They don't seem to do anything, but maybe KDE is doing something else and I'm not noticing it. I probably disabled virtual desktops entirely and forgot about it. |
Ctrl + F{1,2,..} switches desktop indeed on KDE. If it doesn't do anything for you, it's likely that you have only one virtual desktop configured. |
I'm 100% in support of this PR, I think the new shortcuts are very sane -- KDE issues can be fixed by changing the Editor Shortcuts. |
I think I will need some time getting used to this, because I switch with the f-keys very often. But F2 to rename makes sense. |
Why Ctrl not Shift though? Editor Help already uses Shift + F1 and it's easier to press. |
@KoBeWi Shift + F3 is already used for Find Previous in the script editor, and Shift + F4 is used for Uppercase in the script editor. Since main screen-switching shortcuts should work from anywhere, we can't have any conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to break hotkeys for us poor KDE users (always second citizens in the Linux world as Ubuntu is GNOME first), but let's give it a spin and re-assess if the gain is better than the harm.
Cherry-picked for 3.2.4. |
Nooo :( Our pinky will hurt so much, stretching it every time to acrobatic CTRL+F1,F2,F3...). It would be much easier using for example ALT (yes, I know about ALT+F4, but that's a tradeoff, as using Asset Store is not that common as going between views and Script Editor), as it uses thumb, which is then not stretched that much compared to pinky. Or even make configurable if we even want to use that modifier, or - purposely- agree on having conflicts with Rename shortcut? |
@dreamsComeTrue They are configurable. At least for me. Editor > Editor Settings > Shortcuts. |
Thank you! I mislooked that one, I was wrongly assuming, by seeing 'Require' in the title of PR :) |
btw we could bind Search in Help to F1 now. |
@dreamsComeTrue One issue with using Alt as a modifier is that Linux window managers will often intercept it. For instance, I can't use Alt + F1 in applications even though my window manager's manipulation key is set to be Meta instead of Alt. |
I think this is not a good default, as I personally switch between editor views way more often than I rename something. At the least, mentions in changelog that you can rebind hotkeys for this in If I wanna use ctrl+function key without breaking my pinky, I have to use palm of my hand to press ctrl. |
Switching between editors now requires holding Ctrl to avoid conflicts with the new F2 shortcut. Batch renaming has been moved from Shift + F2 to Ctrl + F2 as well.
The asset library can now be accessed by pressing Ctrl + F4 on Windows and Linux, or Alt + 4 on macOS.
Note: The new Ctrl + F1/F2/F3/F4 shortcuts don't seem to work on my KDE/KWin setup. Can anyone else reproduce this? This would be unfortunate, but I think supporting F2 to rename nodes is more important at this point.
This closes #15289. This partially addresses #38139. This partially addresses godotengine/godot-proposals#293.