Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Ctrl for switching between editors, bind F2 to Rename Node #38201

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Apr 25, 2020

Switching between editors now requires holding Ctrl to avoid conflicts with the new F2 shortcut. Batch renaming has been moved from Shift + F2 to Ctrl + F2 as well.

The asset library can now be accessed by pressing Ctrl + F4 on Windows and Linux, or Alt + 4 on macOS.

Note: The new Ctrl + F1/F2/F3/F4 shortcuts don't seem to work on my KDE/KWin setup. Can anyone else reproduce this? This would be unfortunate, but I think supporting F2 to rename nodes is more important at this point.

This closes #15289. This partially addresses #38139. This partially addresses godotengine/godot-proposals#293.

Switching between editors now requires holding Ctrl to avoid
conflicts with the new F2 shortcut.

The asset library can now be accessed by pressing Ctrl + F4
on Windows and Linux, or Alt + 4 on macOS.

This partially addresses godotengine#38139.
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor usability labels Apr 25, 2020
@Calinou Calinou added this to the 4.0 milestone Apr 25, 2020
@Zireael07
Copy link
Contributor

Do they not work at all or do they do something else? KDE has a LOT of shortcuts it uses, IIRC Ctrl+F2 is 'switch to desktop 2'. My personal fav is ctrl+= and ctrl+- zooming regardless of what app I have <3

@Calinou
Copy link
Member Author

Calinou commented Apr 25, 2020

@Zireael07 They don't seem to do anything, but maybe KDE is doing something else and I'm not noticing it. I probably disabled virtual desktops entirely and forgot about it.

@akien-mga
Copy link
Member

Ctrl + F{1,2,..} switches desktop indeed on KDE. If it doesn't do anything for you, it's likely that you have only one virtual desktop configured.

@realkotob
Copy link
Contributor

realkotob commented Apr 25, 2020

I'm 100% in support of this PR, I think the new shortcuts are very sane -- KDE issues can be fixed by changing the Editor Shortcuts.

@Jummit
Copy link
Contributor

Jummit commented Apr 26, 2020

I think I will need some time getting used to this, because I switch with the f-keys very often. But F2 to rename makes sense.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 15, 2020

Why Ctrl not Shift though? Editor Help already uses Shift + F1 and it's easier to press.

@Calinou
Copy link
Member Author

Calinou commented Jul 31, 2020

@KoBeWi Shift + F3 is already used for Find Previous in the script editor, and Shift + F4 is used for Uppercase in the script editor. Since main screen-switching shortcuts should work from anywhere, we can't have any conflicts.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to break hotkeys for us poor KDE users (always second citizens in the Linux world as Ubuntu is GNOME first), but let's give it a spin and re-assess if the gain is better than the harm.

@akien-mga akien-mga merged commit b59a6fc into godotengine:master Nov 17, 2020
@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 17, 2020
@dreamsComeTrue
Copy link
Contributor

dreamsComeTrue commented Nov 22, 2020

Nooo :( Our pinky will hurt so much, stretching it every time to acrobatic CTRL+F1,F2,F3...). It would be much easier using for example ALT (yes, I know about ALT+F4, but that's a tradeoff, as using Asset Store is not that common as going between views and Script Editor), as it uses thumb, which is then not stretched that much compared to pinky.
Can we AT LEAST make that configurable? Like, allowing user to choose own key-modifier for him. Otherwise, hard to admit - but I would definitely switch to using mouse and click on Top-bar view icons as it will bring less pain than making long stretches with left hand :)


Or even make configurable if we even want to use that modifier, or - purposely- agree on having conflicts with Rename shortcut?

@ghost
Copy link

ghost commented Nov 22, 2020

@dreamsComeTrue They are configurable. At least for me. Editor > Editor Settings > Shortcuts.

image

image

image

@dreamsComeTrue
Copy link
Contributor

@dreamsComeTrue They are configurable. At least for me. Editor > Editor Settings > Shortcuts.

image

image

image

Thank you! I mislooked that one, I was wrongly assuming, by seeing 'Require' in the title of PR :)
That's nice it can stay as it was before!

@KoBeWi
Copy link
Member

KoBeWi commented Nov 22, 2020

btw we could bind Search in Help to F1 now.

@Calinou
Copy link
Member Author

Calinou commented Nov 22, 2020

@dreamsComeTrue One issue with using Alt as a modifier is that Linux window managers will often intercept it. For instance, I can't use Alt + F1 in applications even though my window manager's manipulation key is set to be Meta instead of Alt.

@menip
Copy link
Contributor

menip commented Mar 13, 2021

I think this is not a good default, as I personally switch between editor views way more often than I rename something. At the least, mentions in changelog that you can rebind hotkeys for this in Editor > Editor Settings > Shortcuts.

If I wanna use ctrl+function key without breaking my pinky, I have to use palm of my hand to press ctrl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileSystem Tab default OS rename key shortcut
8 participants