Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed underlines and strikethrough not respecting visible character #37656

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

Janglee123
Copy link
Contributor

Fixes #21637

@akien-mga akien-mga added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:gui labels Apr 7, 2020
@akien-mga akien-mga added this to the 4.0 milestone Apr 7, 2020
@akien-mga akien-mga merged commit a10f28f into godotengine:master Apr 7, 2020
@akien-mga
Copy link
Member

Thanks!

@Anutrix
Copy link
Contributor

Anutrix commented Apr 10, 2020

Requesting removal of the cherrypick tag as this causes a regression bug(#37746).

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 10, 2020
@Janglee123
Copy link
Contributor Author

This can be fixed by replacing w with fw in the loop and ENSURE_WIDTH.

@Anutrix
Copy link
Contributor

Anutrix commented Apr 12, 2020

@Janglee123 Do test it and make a PR. Thx.

@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 25, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 1, 2022
@akien-mga akien-mga changed the title Fixed underlines and striketrough not respecting visible character Fixed underlines and strikethrough not respecting visible character Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RichTextLabel underlining does not respect visible character
3 participants